Crud exception rethrow #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases, crud API response process assumes that there are always two response values, which is rather uncommon. The reason of that is internal crud wrappers [1]. This patch reworks response process a bit to more carefully process this unusual case and to not confuse developers. 1. https://github.com/tarantool/crud/blob/53457477974fed42351cbd87f566d11e9f7e39bb/crud/common/schema.lua#L88
Before this patch, all DatabaseError exception, except for ER_NO_SUCH_PROC and ER_ACCESS_DENIED ones, were silently ignored. It resulted in "UnboundLocalError: local variable 'crud_resp' referenced before assignment" instead of a proper error.
DifferentialOrange
added a commit
that referenced
this pull request
Sep 19, 2023
Overview This release fixes crud API exception rethrow bug. Fixed - Exception rethrow in crud API (PR #310).
DifferentialOrange
force-pushed
the
DifferentialOrange/crud-error-rethrow
branch
from
b5eb5d0 to
e0c4a96
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/crud-error-rethrow
branch
from
e0c4a96 to
fdf297e
Compare
better0fdead
approved these changes
Sep 19, 2023
DifferentialOrange
deleted the
DifferentialOrange/crud-error-rethrow
branch
DifferentialOrange
added a commit
that referenced
this pull request
Sep 20, 2023
Overview This release introduce several bugfixes and behavior improvements. Fixed - Exception rethrow in crud API (PR #310). - Work with timestamps larger than year 2038 for some platforms (like Windows) (PR #311). It covers - building new `tarantool.Datetime` objects from timestamp, - parsing datetime objects received from Tarantool.
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Sep 20, 2023
Overview This release introduce several bugfixes and behavior improvements. Fixed - Exception rethrow in crud API (PR #310). - Work with timestamps larger than year 2038 for some platforms (like Windows) (PR #311). It covers - building new `tarantool.Datetime` objects from timestamp, - parsing datetime objects received from Tarantool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, all DatabaseError exception, except for ER_NO_SUCH_PROC and ER_ACCESS_DENIED ones, were silently ignored. It resulted in "UnboundLocalError: local variable 'crud_resp' referenced before assignment" instead of a proper error.